Changeset 287:1b384780a80d

Timestamp:

09/04/11 21:02:19 (5 months ago)

Author:

xeraph

Branch:

default

Convert:

svn:7c3792e6-d75b-4784-96a6-b298f655ee64/trunk@2721

Message:

reset login failures if login succeeded

File:

• kraken-dom/src/main/java/org/krakenapps/dom/api/impl/AdminApiImpl.java (modified) (2 diffs)

kraken-dom/src/main/java/org/krakenapps/dom/api/impl/AdminApiImpl.java

@@ -61 +61 @@
 
                 if (hash.equals(Sha1.hash(admin.getUser().getPassword() + nonce)) == false) {
-                        updateLoginFailures(admin);
+                        updateLoginFailures(admin, false);
                         throw new InvalidPasswordException();
-                }
+                } else
+                        updateLoginFailures(admin, true);
 
                 return admin;
@@ -69 +70 @@
 
         @Transactional
-        private void updateLoginFailures(Admin admin) {
+        private void updateLoginFailures(Admin admin, boolean success) {
                 EntityManager em = entityManagerService.getEntityManager();
                 admin = em.find(Admin.class, admin.getId());
-                admin.setLoginFailures(admin.getLoginFailures() + 1);
-                logger.debug("kraken dom: login [{}] login failures [{}]", admin.getUser().getName(), admin.getLoginFailures());
-
-                if (admin.isUseLoginLock() && admin.getLoginFailures() >= admin.getLoginLockCount())
-                        admin.setEnabled(false);
+
+                if (success) {
+                        admin.setLoginFailures(0);
+                } else {
+                        admin.setLoginFailures(admin.getLoginFailures() + 1);
+                        if (admin.isUseLoginLock() && admin.getLoginFailures() >= admin.getLoginLockCount())
+                                admin.setEnabled(false);
+                }
 
                 em.merge(admin);