Changeset 343:7f06d669913d for kraken-linux-api/src/main/java/org/krakenapps/linux/api/UdpConnectionInformation.java

Timestamp:

09/18/11 13:55:15 (8 months ago)

Author:

xeraph

Branch:

default

Convert:

svn:7c3792e6-d75b-4784-96a6-b298f655ee64/trunk@2777

Message:

• fixed potential handle leak bugs.
• added missing license terms

File:

• kraken-linux-api/src/main/java/org/krakenapps/linux/api/UdpConnectionInformation.java (modified) (1 diff)

kraken-linux-api/src/main/java/org/krakenapps/linux/api/UdpConnectionInformation.java

@@ -78 +78 @@
                 List<ConnectionInformation> stats = new ArrayList<ConnectionInformation>();
                 BufferedReader br = null;
-
-                br = new BufferedReader(new InputStreamReader(new FileInputStream(new File(filePath))));
-                br.readLine(); // ignore column name line
-                while (true) {
-                        String line = br.readLine();
-                        if (line == null)
-                                break;
-
-                        if (filePath.endsWith("udp"))
-                                stats.add(parse(line, 4, uidToPid));
-                        else if (filePath.endsWith("udp6"))
-                                stats.add(parse(line, 16, uidToPid));
-                }
+                FileInputStream is = null;
 
                 try {
-                        br.close();
-                } catch (IOException e) {
+                        is = new FileInputStream(new File(filePath));
+                        br = new BufferedReader(new InputStreamReader(is));
+                        br.readLine(); // ignore column name line
+                        while (true) {
+                                String line = br.readLine();
+                                if (line == null)
+                                        break;
+
+                                if (filePath.endsWith("udp"))
+                                        stats.add(parse(line, 4, uidToPid));
+                                else if (filePath.endsWith("udp6"))
+                                        stats.add(parse(line, 16, uidToPid));
+                        }
+                } finally {
+                        if (is != null)
+                                is.close();
+                        if (br != null)
+                                br.close();
                 }